Skip to content

Dialog: Fix off() -> unbind() for jQuery 1.6 compat #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Dialog: Fix off() -> unbind() for jQuery 1.6 compat #1256

wants to merge 1 commit into from

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented May 27, 2014

Follows-up c9815f1.

There's a unit test failure unconditionally in all browsers when using jQuery 1.6:

10. dialog: core: #7960: resizable handles below modal overlays (2, 1, 3) 23 ms
Resizable handles have lower z-index than modal overlay
Died on test #2     at /tests/unit/dialog/dialog_core.js:128:1
    at /tests/unit/dialog/dialog_core.js:231:3: undefined is not a function
Source:     
TypeError: undefined is not a function
    at $.widget._destroyOverlay (/ui/dialog.js:846:7)
    at null._destroyOverlay (/ui/widget.js:108:25)
    at $.widget._destroy (/ui/dialog.js:153:8)
    at null._destroy (/ui/widget.js:108:25)
    at $.Widget.destroy (/ui/widget.js:286:8)
    at HTMLDivElement.<anonymous> (/ui/widget.js:206:39)
    at Function.jQuery.extend.each (/tests/jquery-1.6.js:641:20)
    at jQuery.fn.jQuery.each (/tests/jquery-1.6.js:265:17)
    at $.fn.(anonymous function) [as dialog] (/ui/widget.js:192:9)
    at Object.<anonymous> (/tests/unit/dialog/dialog_core.js:137:9)
Expected 1 assertions, but 2 were run
Source:     
    at /tests/unit/dialog/dialog_core.js:128:1
    at /tests/unit/dialog/dialog_core.js:231:3

Fixes #10072

@tjvantoll tjvantoll closed this in 6c40052 May 27, 2014
@Krinkle Krinkle deleted the dialog-core1-6compat branch May 27, 2014 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Krinkle